|Summary:||Gigedit missing a batch replace function for samples|
|Product:||gigedit||Reporter:||Anders Dahnielson <anders>|
|Component:||gigedit||Assignee:||Andreas Persson <andreas56>|
Patch to add simple batch replacement functionality
Trial to circumvent the line wrap bug of Gtk::Label
Description Anders Dahnielson 2008-02-03 17:54:52 CET
Currently gigedit is missing a batch replace function for samples.
Comment 1 Anders Dahnielson 2008-02-03 17:58:08 CET
Created attachment 21 [details] Patch to add simple batch replacement functionality This patch add an item to the samples tree pop-up menu that let you select a folder with wav files that will be imported and replace samples with the same name already in the gig file.
Comment 2 Christian Schoenebeck 2008-02-06 20:31:21 CET
Seems Andreas is busy. I review the patch now.
Comment 3 Christian Schoenebeck 2008-02-06 23:19:42 CET
Ok, I just commited it to CVS. I extended your patch a bit: * the postfix for the filename (was hardcoded ".wav") is now user adjustable by an entry box in the directory select dialog * added a detailed description about this function to the directory select dialog, because I think the regular user would be absolutely clueless what to do do with this function (note the ugly line wrap behavior of the description label: it doesn't adjust correctly to the correct dialog size yet, which is a gtkmm issue I haven't found a workaround yet - see also the commented FIXME code which I tried to fix this issue) * using G_DIR_SEPARATOR_S instead of "/" to keep the code portable * showing an error dialog at the end with all samples that failed to replace Thanks Anders!
Comment 4 Christian Schoenebeck 2008-02-07 15:40:40 CET
Created attachment 22 [details] Trial to circumvent the line wrap bug of Gtk::Label This is BTW the last thing I tried yesterday to circumvent the mentioned bug of Gtk::Label regarding line wrapping of long text. I tried to call Gtk::Label::set_size_request() each time the dialog resizes, because that call was recommended in the gtkmm API docs to circumvent the problem, but unfortunately it will only set the minimum widget size of the label. That is, the text will correctly adjust itself to the parent's container size, but you won't be a able to shrink the dialog anymore... you can only enlarge it more and more. :)
Comment 5 Christian Schoenebeck 2008-12-03 00:00:05 CET
Should we fix that previously mentioned Gtk::Label line wrapping issue in the dialog? Otherwise I suggest to close this report.
Comment 6 Andreas Persson 2008-12-06 14:52:59 CET
I found a label implementation that seems to line wrap correctly in "libview", http://view.sourceforge.net/, and copied it to gigedit.
Comment 7 Christian Schoenebeck 2008-12-11 02:35:34 CET
Closing this report now, due to the current huge list.