|Summary:||Support for RPNs "Pitch Bend Range" and "Fine Tuning"|
|Product:||LinuxSampler||Reporter:||Luis Garrido <luisgarrido>|
|Component:||gig::Engine||Assignee:||Christian Schoenebeck <cuse>|
Description Luis Garrido 2009-04-08 14:40:35 CEST
Hi! I was trying to achieve certain detuning effect and found out that LS doesn't support "Pitch Bend Range" and "Fine Tuning" RPNs. Is this consistent with GS behaviour and should stay so by design? I had a look at the gig engine source code and, at first glance, they seem pretty easy to implement: add a couple of member variables to gig::EngineChannel (e.g. GlobalPitchBendRange and GlobalFineTune), update them at Engine::ProcessControlChange and consider them at a couple of appropriate places in Voice.cpp. I think the more sensible behaviour would be that GlobalPitchBendRange overrides pInstrument->PitchbendRange and that GlobalFineTune is added to pInstrument-FineTune and pDimRgn->FineTune.
Comment 1 Christian Schoenebeck 2013-05-31 19:39:08 CEST
Yes, this would be easy to be implemented. Do you have a patch for your suggestion?