Bug 125 - Support for RPNs "Pitch Bend Range" and "Fine Tuning"
Summary: Support for RPNs "Pitch Bend Range" and "Fine Tuning"
Status: ASSIGNED
Alias: None
Product: LinuxSampler
Classification: Unclassified
Component: gig::Engine (show other bugs)
Version: SVN Trunk
Hardware: PC Linux
: P2 enhancement
Assignee: Christian Schoenebeck
URL:
Depends on:
Blocks:
 
Reported: 2009-04-08 14:40 CEST by Luis Garrido
Modified: 2013-05-31 19:39 CEST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luis Garrido 2009-04-08 14:40:35 CEST 
Hi! I was trying to achieve certain detuning effect and found out that LS
doesn't support "Pitch Bend Range" and "Fine Tuning" RPNs. Is this consistent
with GS behaviour and should stay so by design?

I had a look at the gig engine source code and, at first glance, they seem
pretty easy to implement: add a couple of member variables to gig::EngineChannel
(e.g. GlobalPitchBendRange and GlobalFineTune), update them at
Engine::ProcessControlChange and consider them at a couple of appropriate places
in Voice.cpp.

I think the more sensible behaviour would be that GlobalPitchBendRange overrides
pInstrument->PitchbendRange and that GlobalFineTune is added to
pInstrument-FineTune and pDimRgn->FineTune.
Comment 1 Christian Schoenebeck 2013-05-31 19:39:08 CEST 
Yes, this would be easy to be implemented. Do you have a patch for your suggestion?