Bug 104 - Libgig is interpreting single quotes inside of .gig files wrong
Summary: Libgig is interpreting single quotes inside of .gig files wrong
Status: CLOSED FIXED
Alias: None
Product: JSampler
Classification: Unclassified
Component: JSampler (show other bugs)
Version: SVN Trunk
Hardware: PC Linux
: P2 blocker
Assignee: Grigor Iliev
URL:
Depends on:
Blocks:
 
Reported: 2008-09-29 08:14 CEST by Chris Cherrett
Modified: 2008-12-11 02:45 CET (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cherrett 2008-09-29 08:14:01 CEST 
Here ia a dump of one of the many offending files:

http://www.tsiwebdesign.com/testing/Flute2GIG.dump

Here is a quick view of part of the dump:

Sample 2) "FL2_cre2_1'5s_mf-ff_C5", Group 1, 44100Hz, 2 Channels, 0 Loops,
Length=113746 Compressed=false
    Sample 3) "FL2_cre2_1'5s_mf-ff_D4", Group 1, 44100Hz, 2 Channels, 0 Loops,
Length=112177 Compressed=false
    Sample 4) "FL2_cre2_1
Comment 1 Chris Cherrett 2008-09-29 08:16:12 CEST 
Ok crazy the character in question quoted the entry and cut it off.

Please refer to the actual file:

http://www.tsiwebdesign.com/testing/Flute2GIG.dump
Comment 2 Anders Dahnielson 2008-09-29 22:03:48 CEST 
Same as Bug #75 (wasn't it fixed?)

https://bugs.linuxsampler.org/cgi-bin/show_bug.cgi?id=75
Comment 3 Chris Cherrett 2008-09-29 22:49:57 CEST 
It does not appear to be fixed for me. It is not just the instrument names it is
also the individual sample names that are hurt by it.
Comment 4 Christian Schoenebeck 2008-09-30 01:08:43 CEST 
I don't see this to be a bug in libgig. Since the characters in question are 
UTF8, it's natural that they're encoded with more than one character. So I 
think this hast to be fixed on frontend side.
Comment 5 Grigor Iliev 2008-09-30 05:20:17 CEST 
I just added support for escaping unicode characters in jlscp. Please, recompile
jlscp and jsampler and let me know if this fixes the issue.
Comment 6 Chris Cherrett 2008-09-30 09:54:15 CEST 
all fixed!

Thanks!
Comment 7 Grigor Iliev 2008-09-30 11:17:14 CEST 
Marked the bug as fixed.
Thanks.