The following categories returns -1 instead of "NONE" when they are not set.
The following categories are set to -1 but they are not specified in LSCP draft, so
not sure about them.
btw INSTRUMENT_NAME also is not specified in LSCP and return "NONE"
Sending patch for lscpserver.cpp
Created attachment 6 [details]
patch for lscpserver.cpp
I will postpone this after I got the release packaged and out. Because it might
break compatibility with liblscp and qsampler.
Altough it might not conform to current LSCP spec, the AUDIO_OUTPUT_DEVICE and
MIDI_INPUT_DEVICE fields of the GET CHANNEL INFO command result set are
assumed to be integers on liblscp.
The proposed change will surely break liblscp (0.2.9) and qsampler (0.1.0)
behavior, as reading atoi("NONE") leads to a device number zero (0), which is
a valid device-id and not minus-one (-1), which is not.
However, the point is taken, and should be addressed in near term.
What should we do with this issue? I guess there's no point in modifying the
implementation anymore, since it would introduce the mentioned backward
Should we just update the LSCP specs regarding the mentioned lack of
clearification and mark this report as resolved?
ok, I'm fine with that.
Ok, fixed the LSCP sepcs as suggested.