Bug 9 - inconsistency in protocol regarding GET AVAILABLE_ENGINES command
Summary: inconsistency in protocol regarding GET AVAILABLE_ENGINES command
Status: CLOSED FIXED
Alias: None
Product: LinuxSampler
Classification: Unclassified
Component: LSCP (show other bugs)
Version: SVN Trunk
Hardware: Other Linux
: P2 normal
Assignee: Christian Schoenebeck
URL:
Depends on:
Blocks:
 
Reported: 2005-04-06 21:18 CEST by Christian Schoenebeck
Modified: 2005-05-11 01:05 CEST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Schoenebeck 2005-04-06 21:18:43 CEST 
I just noticed that we have a a little inconsistency in the protocol regarding 
the "GET AVAILABLE_ENGINES" command which does not behave as somebody might 
expect compared to similar commands like "GET AVAILABLE_AUDIO_OUTPUT_DRIVERS".  
 
Currently "GET AVAILABLE_ENGINES" returns a comma separated list with the 
engine's names. To keep consistency I think we should change this so that "GET 
AVAILABLE_ENGINES" just returns the number of available engines, and introduce 
a new command "LIST AVAILABLE_ENGINES" which actually returns the comma 
separated list of engine names.
Comment 1 Rui Nuno Capela 2005-05-06 09:55:42 CEST 
Now that I get th review the current LSCP spec, there's also these commands 
that fall in the same naming inconsistency:
  GET AVAILABLE_AUDIO_OUTPUT_DRIVERS
  GET AVAILABLE_MIDI_INPUT_DRIVERS
which are returning a comma separated list of available drivers. Using the 
suggested rationale, those should return the driver count and the following new 
commands should be proposed, respectively:
  LIST AVAILABLE_AUDIO_OUTPUT_DRIVERS
  LIST AVAILABLE_MIDI_INPUT_DRIVERS
Comment 2 Christian Schoenebeck 2005-05-11 01:04:53 CEST 
Fixed with LinuxSampler 0.3.1, liblscp 0.2.8. LSCP specification document 
updated as well.